Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: fix indent bug on comments in ternary expressions (fixes #9729) #9818

Merged
merged 1 commit into from Jan 10, 2018
Merged

Update: fix indent bug on comments in ternary expressions (fixes #9729) #9818

merged 1 commit into from Jan 10, 2018

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (#9729)

What changes did you make? (Give an overview)

This updates the indent rule to fix an issue where comments would interfere with token logic.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint indent Relates to the `indent` rule rule Relates to ESLint's core rules labels Jan 7, 2018
platinumazure
platinumazure approved these changes Jan 7, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit add1e70 into master Jan 10, 2018
@not-an-aardvark not-an-aardvark deleted the indent-commented-ternary-expressions branch January 10, 2018 00:05
@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
This was referenced Mar 8, 2018
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 10, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint indent Relates to the `indent` rule rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@not-an-aardvark @platinumazure @ilyavolodin