Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Deactivate consistent-docs-url in internal rules folder #9815

Merged
merged 1 commit into from Jan 14, 2018

Conversation

platinumazure
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Deactivating consistent-docs-url rule on our other internal rules, since we intentionally don't document them

What changes did you make? (Give an overview)

Deactivated consistent-docs-url rule on our other internal rules, since we intentionally don't document those rules.

Is there anything you'd like reviewers to focus on?

Not really.

@not-an-aardvark
Copy link
Member

Separately from this PR, I wonder if it would be better to add a unit test which asserts that the correct url is present on everything in Linter#getRules, rather than using a linting rule (which could potentially be confused by modifications at runtime/unexpected syntax)

@platinumazure
Copy link
Member Author

@not-an-aardvark Possibly... We could also run that lint operation separately and use --no-inline-config to reduce the risk of that, in theory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants