Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add note about "patch release pending" label to maintainer guide #9763

Merged
merged 2 commits into from Dec 24, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

This updates the release guide to ensure that the release team adds the post-release label to the release issue when a patch release is pending.

Is there anything you'd like reviewers to focus on?

  • Should we give the post-release label a better name? I was thinking something like patch release pending would be more clear. If we do change this, we should also update the constant string in eslint-github-bot.
  • With the bot running, I don't think it's necessary to leave a reminder comment about only merging semver-patch PRs, because the bot should prevent those PRs from being merged anyway. However, I left that comment for the time being (just in case the bot runs into problems on its first release).

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Dec 24, 2017
@not-an-aardvark
Copy link
Member Author

Closing/reopening to restart the appveyor build.

@platinumazure
Copy link
Member

I like "patch release pending" much better. If that's not too difficult a change, I would strongly 👍 that name.

@not-an-aardvark
Copy link
Member Author

Created eslint/eslint-github-bot#50 to update the label name on the bot. After that is merged/deployed, I'll rename the label on the eslint/eslint repo and update this PR.

@not-an-aardvark not-an-aardvark added the do not merge This pull request should not be merged yet label Dec 24, 2017
not-an-aardvark added a commit to eslint/eslint-github-bot that referenced this pull request Dec 24, 2017
not-an-aardvark added a commit to eslint/eslint-github-bot that referenced this pull request Dec 24, 2017
@not-an-aardvark not-an-aardvark changed the title Docs: Add note about post-release label to maintainer guide Docs: Add note about "patch release pending" label to maintainer guide Dec 24, 2017
@platinumazure
Copy link
Member

Probably good to get a second set of TSC eyes to make sure the process looks okay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion do not merge This pull request should not be merged yet documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants