Update: Logical-and is counted in complexity rule (fixes #8535)
#9754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumazure
added
accepted
lib/rules/complexity.js
Outdated
|
|
||
| // Avoiding && | ||
| if (node.operator === "||") { | ||
| if (node.operator === "&&" || node.operator === "||") { |
There was a problem hiding this comment.
Could this if statement be removed?
There was a problem hiding this comment.
In fact, I can remove the whole function!
|
@not-an-aardvark Please take another look, at your convenience. Thanks! |
not-an-aardvark
approved these changes
Dec 22, 2017
mysticatea
approved these changes
Dec 22, 2017
|
Closing/reopening to attempt another AppVeyor build. |
gyandeeps
approved these changes
Dec 23, 2017
|
This was a breaking change |
|
@jking90 ESLint’s policy is that a minor release can break your build, and they recommend using |
|
@j-f1 thanks for clarifying |
This was referenced Mar 8, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #8535.
What changes did you make? (Give an overview)
Logical-and now counts the same as logical-or for increasing cyclomatic complexity in a function. (
a && bis the same as!(!a || !b), so either operator should increase complexity)Since this change will result in strictly non-decreasing complexity, this will result in more warnings reported, hence "Update".
Is there anything you'd like reviewers to focus on?
Not really.