Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add unit tests for overrides glob matching. #9744

Merged

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Dec 20, 2017

Adds unit tests for lib/config/config-ops.js's pathMatchesGlobs utility method. This does not include any changes to the implementation at all, and is intended to make it easier to grok any changes made while addressing #9740.

@rwjblue rwjblue force-pushed the add-unit-tests-for-path-matches-globs branch 2 times, most recently from 5f1aeba to c23bf69 Compare December 20, 2017 19:05
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding these!

@rwjblue rwjblue force-pushed the add-unit-tests-for-path-matches-globs branch from c23bf69 to 97dc29d Compare December 20, 2017 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants