Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Make the lint message source property a little more subtle #9735

Merged
merged 1 commit into from Dec 19, 2017

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Dec 18, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
I made the deprecated message.source property a little more subtle so that people don’t try to use it. I removed it from all of the examples, and adjusted the warning text at the end of the section

Is there anything you'd like reviewers to focus on?

How’s my wording?

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but want to get a second set of eyes on this.

@aladdin-add aladdin-add merged commit f252c19 into eslint:master Dec 19, 2017
@aladdin-add
Copy link
Member

thanks for contributing! @j-f1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants