test: fix test-suite to work with node master #9688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MylesBorins
force-pushed
the
fix-test-suite-for-node-master
branch
from
a5127ef
to
d3f9239
Compare
4 tasks
j-f1
reviewed
Dec 5, 2017
tests/lib/testers/rule-tester.js
Outdated
| @@ -126,7 +126,7 @@ describe("RuleTester", () => { | |||
| { code: "var foo = bar;", errors: [{ message: "Bad error message." }] } | |||
| ] | |||
| }); | |||
| }, /Bad var\..*==.*Bad error message/); | |||
| }, /Bad var\.((.*==)||(strict equal)).*Bad error message/); | |||
There was a problem hiding this comment.
I think you just need one | here.
tests/lib/testers/rule-tester.js
Outdated
| @@ -167,7 +167,7 @@ describe("RuleTester", () => { | |||
| { code: "var foo = bar;", errors: ["Bad error message."] } | |||
| ] | |||
| }); | |||
| }, /Bad var\..*==.*Bad error message/); | |||
| }, /Bad var\.((.*==)||(strictEqual)).*Bad error message/); | |||
not-an-aardvark
approved these changes
Dec 5, 2017
There was a problem hiding this comment.
LGTM, thanks!
I agree with @j-f1's comments, although I don't think they're blockers.
Changes to the output of strictEqual are breaking the test suite This minor adjustment to the regex will fix Node 10+ while keeping support for older versions of node
MylesBorins
force-pushed
the
fix-test-suite-for-node-master
branch
from
d3f9239
to
5aba33f
Compare
|
Updated with notes PTAL. Was thinking JS and not regex... || actually was causing the expression to always pass 😅 Replaced with single | and added |
gyandeeps
approved these changes
Dec 5, 2017
|
Thanks! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Changes to the output of strictEqual are breaking the test suite
This minor adjustment to the regex will fix Node 10+ while keeping
support for older versions of node