New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Add NewExpression support to comma-style #9591
Update: Add NewExpression support to comma-style #9591
Conversation
@eslint/eslint-team Does anyone else wants to support this change? We need one more 👍 and a champion |
This seems like a reasonable enhancement to me! We just need a champion now. |
I'll champion this. Marking as accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for contributing! |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What rule do you want to change?
comma-style
Does this change cause the rule to produce more or fewer warnings?
more, if new option is enabled
How will the change be implemented? (New option, new default behavior, etc.)?
New
exceptions.NewExpression
option, which defaults to true, and can be set to false for the new behaviour.Please provide some example code that this change will affect:
What does the rule currently do for this code?
No errors.
What will the rule do after it's changed?
Gives an error that
',' should be placed last.
What changes did you make? (Give an overview)
I added a
NewExpression
exception in the same style as the existingcomma-style
exceptions (FunctionExpression
etc.)Is there anything you'd like reviewers to focus on?