Build: remove shelljs-nodecli (fixes #9533) #9588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `shelljs-nodecli` module from the build process. `shelljs-nodecli` relies on a very old version of the `shelljs` module, which might be causing a flaky build on Appveyor (see #9533 for details). In any case, removing `shelljs-cli` seem to make `npm test` run 40% faster anyway, so it should be an improvement even if it doesn't fix the Appveyor build.
not-an-aardvark
added
accepted
|
I'm going to try redelivering the Appveyor webhook a few times to see if it fails. |
|
The Appveyor build has passed 5 times in a row on this PR, so maybe it does fix the flakiness. |
not-an-aardvark
changed the title
gyandeeps
approved these changes
Nov 7, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This removes the
shelljs-nodeclimodule from the build process.shelljs-nodeclirelies on a very old version of theshelljsmodule, which might be causing a flaky build on Appveyor (see #9533 for details). In any case, removingshelljs-cliseem to makenpm testrun 40% faster anyway, so it should be an improvement even if it doesn't fix the Appveyor build.Fixes #9533
Is there anything you'd like reviewers to focus on?
Nothing in particular