Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: disallow use of the comma operator using no-restricted-syntax #9585

Merged
merged 4 commits into from Nov 10, 2017

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

refs: #9465 (comment)

Is there anything you'd like reviewers to focus on?
no.

@aladdin-add aladdin-add added the documentation Relates to ESLint's documentation label Nov 5, 2017
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, otherwise LGTM. Thanks!

@@ -66,7 +66,7 @@ while ((val = foo(), val < 42));
## When Not To Use It

Disable this rule if sequence expressions with the comma operator are acceptable.
Another case where you might want to reports all usages of the comma operator, even if they are wrapped in parenthesis or in a for loop. You can achieve this using rule `no-restricted-syntax`:
Another case is where you might want to reports all usages of the comma operator, even if they are wrapped in parenthesis or in a for loop. You can achieve this using rule `no-restricted-syntax`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: parenthesis (should be parentheses; "parenthesis" is the singular noun, while "parentheses" is the plural)

@ilyavolodin ilyavolodin merged commit d4557a6 into master Nov 10, 2017
@not-an-aardvark not-an-aardvark deleted the Aladdin-ADD-patch-1 branch November 10, 2017 20:59
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 10, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants