Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Minor rephrase in no-invalid-this. #9542

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Francisc
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Minor rephrase, check diff.

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@platinumazure
Copy link
Member

@eslint/eslint-team It looks like the Travis and AppVeyor builds might be broken due to an upstream dependency issue of some kind. Anyone know what might be going on?

@not-an-aardvark
Copy link
Member

See #9539 (comment)

@Francisc
Copy link
Contributor Author

Thanks as well.

@not-an-aardvark
Copy link
Member

Closing and reopening this PR to trigger a rebuild.

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Oct 31, 2017
@not-an-aardvark not-an-aardvark merged commit acccfbd into eslint:master Oct 31, 2017
@not-an-aardvark
Copy link
Member

Thanks for contributing!

@Francisc Francisc deleted the patch-3 branch October 31, 2017 10:25
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 30, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants