Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: object-curly-newline for flow code #9458

Merged

Commits on Oct 16, 2017

  1. Fix: object-curly-newline for flow code (fixes babel-eslint/513)

    The `object-curly-newline` rule made the assumption that the last token
    is always `}`. However, when an object is typed with flow this is not
    the case. This causes false positives, as described in babel/babel-eslint#513.
    
    By adding a filter to the `getLastToken` function we skip over the flow
    types, and get the actual closing brace. For symmetry the same filter is
    added for the open brace, though I'm not aware of any issues it would
    fix.
    TiddoLangerak committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    5256234 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. Fix object-curly-newline for flow type literals & added tests

    - Added tests for `object-curly-newline` in code annotated with flow types
    - Fixed incorrect behaviour of object-curly-newline for literal object types
    TiddoLangerak committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    38b6105 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2017

  1. Configuration menu
    Copy the full SHA
    d5871d7 View commit details
    Browse the repository at this point in the history