Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Reorganized to avoid misunderstandings. #9434

Merged
merged 1 commit into from Oct 14, 2017
Merged

Docs: Reorganized to avoid misunderstandings. #9434

merged 1 commit into from Oct 14, 2017

Conversation

jrpool
Copy link
Contributor

@jrpool jrpool commented Oct 13, 2017

Original headings made it seem that sections after Step 5 could be additional steps.
And summary of workflow without a link to the full workflow could make a reader think
that the summary is the whole workflow.

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Reorganized headings to cleanly distinguish the 5 steps from the following reference info,
and reduced the workflow summary to a reference to the full workflow documentation, to
prevent contributors from mis-believing that the summary is the entire workflow. This also
implies that any revision in the workflow need not be made in 2 places.

Is there anything you'd like reviewers to focus on?

Original headings made it seem that sections after Step 5 could be additional steps. And summary of workflow
without a link to the full workflow could make a reader think that the summary is the whole workflow.
@eslintbot
Copy link

LGTM

@aladdin-add aladdin-add added the documentation Relates to ESLint's documentation label Oct 14, 2017
@not-an-aardvark not-an-aardvark merged commit 02732bd into eslint:master Oct 14, 2017
@not-an-aardvark
Copy link
Member

Thanks for contributing!

@jrpool jrpool deleted the devenvdocreorg branch October 14, 2017 02:51
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 13, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants