Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: avoid loose equality assertions #9415

Merged
merged 3 commits into from Oct 14, 2017
Merged

Chore: avoid loose equality assertions #9415

merged 3 commits into from Oct 14, 2017

Commits on Oct 12, 2017

  1. Chore: avoid loose equality assertions 

    This updates the `no-restricted-syntax` configuration to disallow
`assert.equal` and `assert.notEqual` in favor of `assert.strictEqual`
and `assert.notStrictEqual`. It also fixes a few places where the tests
were relying on a loose equality check (e.g. comparing a single-element
    array to a string).
    @not-an-aardvark
    not-an-aardvark committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    ab7b455 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2017

  1. Use assert.deepStrictEqual instead of assert.deepEqual

    @not-an-aardvark
    not-an-aardvark committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    4bdd1e4 View commit details
    Browse the repository at this point in the history

  2. Revert accidental fixture changes

    @not-an-aardvark
    not-an-aardvark committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    23cb24d View commit details
    Browse the repository at this point in the history