Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add missing space in blog post template #9407

Merged
merged 1 commit into from Oct 10, 2017

Conversation

platinumazure
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Fix an issue with the blog post template (used for generating blog posts on release).

What changes did you make? (Give an overview)

For non-patch releases, template used to generate this string:

This release adds some new features andfixes several bugs found in the previous release.

Now it generates this string:

This release adds some new features and fixes several bugs found in the previous release.

Is there anything you'd like reviewers to focus on?

Not really.

For non-patch releases, template used to generate this string:

> This release adds some new features andfixes several bugs found in the previous release.

Now it generates this string:

> This release adds some new features and fixes several bugs found in the previous release.
@eslintbot
Copy link

LGTM

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Oct 10, 2017
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goodto me, thanks!

@platinumazure
Copy link
Member Author

@not-an-aardvark

Looks goodto me, thanks!

Was that intentional/ironic? 😄

@not-an-aardvark
Copy link
Member

ᕕ( ᐛ )ᕗ

@ilyavolodin ilyavolodin merged commit 9fedd51 into master Oct 10, 2017
@ilyavolodin ilyavolodin deleted the platinumazure-patch-1 branch October 10, 2017 20:41
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 9, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants