Docs: clarify no-mixed-operators (fixes #8051) #9404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ruxandrafed
force-pushed
the
no-mixed-operators-doc
branch
from
c4cf466
to
33180f6
Compare
|
LGTM |
aladdin-add
reviewed
Oct 11, 2017
docs/rules/no-mixed-operators.md
Outdated
| @@ -9,6 +9,21 @@ var foo = (a && b) || c || d; /*GOOD*/ | |||
| var foo = a && (b || c || d); /*GOOD*/ | |||
| ``` | |||
|
|
|||
| **Note:** | |||
| It is expected for this rule to emit one error for each mixed operator in a pair. As a result, for each two consecutive mixed operators used, a distinct error will be displayed, pointing to the where the specific operator that breaks the rule is used: | |||
There was a problem hiding this comment.
Nits: pointing to the where...
"the" should be removed?
There was a problem hiding this comment.
Oops! Thanks @aladdin-add, I removed it.
Update docs for `no-mixed-operators` to clarify that a pair of errors will be triggered for each pair of mixed consecutive operators used. Fixes eslint#8051.
ruxandrafed
force-pushed
the
no-mixed-operators-doc
branch
from
33180f6
to
3217eea
Compare
|
LGTM |
kaicataldo
approved these changes
Oct 11, 2017
|
LGTM. Thanks for contributing to ESLint! |
kaicataldo
changed the title
no-mixed-operators rule
kaicataldo
changed the title
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs for
no-mixed-operatorsto clarify that a pair of errors will be triggered for each pair of mixed consecutive operators used. Fixes #8051.What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Just an update to the documentation for the
no-mixed-operatorsrule.Is there anything you'd like reviewers to focus on?