Update: Add FunctionExpression to require-jsdoc (fixes #5867) #9395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
suggested changes
Oct 6, 2017
lib/rules/require-jsdoc.js
Outdated
| checkClassMethodJsDoc(node); | ||
| if ( | ||
| (options.MethodDefinition && node.parent.type === "MethodDefinition") || | ||
| (options.FunctionExpression && (node.parent.type === "VariableDeclarator" || node.parent.type === "Property")) |
There was a problem hiding this comment.
Should the node.parent.type === "Property" check also verify that node === node.parent.value?
Otherwise, I think something like this will be reported:
var foo = {
[function() {}]: 1
};
|
LGTM |
not-an-aardvark
approved these changes
Oct 6, 2017
not-an-aardvark
added
accepted
kaicataldo
force-pushed
the
fixes5867
branch
2 times, most recently
from
e0002a2
to
7365f7d
Compare
|
LGTM |
ilyavolodin
approved these changes
Oct 14, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixes #5867.
Add a
FunctionExpressionconfiguration option to therequire-jsdocrule.Is there anything you'd like reviewers to focus on?
Nothing in particular!