Chore: Error => TypeError #9390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
platinumazure
approved these changes
Oct 5, 2017
lib/util/node-event-generator.js
Outdated
| @@ -160,7 +160,7 @@ function tryParseSelector(rawSelector) { | |||
| return esquery.parse(rawSelector.replace(/:exit$/, "")); | |||
| } catch (err) { | |||
| if (typeof err.offset === "number") { | |||
| throw new Error(`Syntax error in selector "${rawSelector}" at position ${err.offset}: ${err.message}`); | |||
| throw new TypeError(`Syntax error in selector "${rawSelector}" at position ${err.offset}: ${err.message}`); | |||
There was a problem hiding this comment.
Is a TypeError semantically correct here (as opposed to, e.g. a SyntaxError)? This error doesn't seem to relate to types.
|
LGTM |
not-an-aardvark
approved these changes
Oct 5, 2017
kaicataldo
approved these changes
Oct 5, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
throw a TypeError after a type checking if-statement, instead of a generic Error.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?