Chore: avoid handling rules instances in config-validator #9364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ilyavolodin
reviewed
Oct 14, 2017
|
The goal of this change is to progress towards being able to remove the |
|
Just to clarify, when you are talking about |
|
Yes, that's correct. |
ilyavolodin
approved these changes
Oct 27, 2017
|
@not-an-aardvark Could you rebase please? |
This is a modified version of #9277, which was merged but then reverted later for performance reasons. The performance issues from #9177 have been fixed (`Linter` no longer creates a new map of rules whenever it lints text). The goal of this change is to progress towards being able to remove the `rules` property from `Linter` instances. Unfortunately, this isn't possible yet, since there are a few other modules that rely on reading the list of defined rules.
not-an-aardvark
force-pushed
the
reduce-rules-access
branch
from
f2f22a6
to
cdc6dbe
Compare
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
This is a modified version of #9277, which was merged but then reverted later for performance reasons. The performance issues from #9177 have been fixed (
Linterno longer creates a new map of rules whenever it lints text).The goal of this change is to progress towards being able to remove the
rulesproperty fromLinterinstances. Unfortunately, this isn't possible yet, since there are a few other modules that rely on reading the list of defined rules.Is there anything you'd like reviewers to focus on?
Nothing in particular