Chore: remove sourceCode property from Linter (refs #9161) #9363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This removes the
sourceCode
property fromLinter
instances, as part of the ongoing effort in #9161 to reduce undocumented API surface area.The
sourceCode
property was used becauseLinter
has agetSourceCode
method which points to theSourceCode
instance from the lastverify
call. This is unfortunate, because it preventsLinter#verify
from being side-effect-free as described in #9161. However, we can't remove it right now, because it's documented here. Eventually I think we should deprecate and remove that, but that is a separate issue.Is there anything you'd like reviewers to focus on?
Nothing in particular