Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove sourceCode property from Linter (refs #9161) #9363

Merged
merged 1 commit into from Sep 29, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This removes the sourceCode property from Linter instances, as part of the ongoing effort in #9161 to reduce undocumented API surface area.

The sourceCode property was used because Linter has a getSourceCode method which points to the SourceCode instance from the last verify call. This is unfortunate, because it prevents Linter#verify from being side-effect-free as described in #9161. However, we can't remove it right now, because it's documented here. Eventually I think we should deprecate and remove that, but that is a separate issue.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Sep 27, 2017
@eslintbot
Copy link

LGTM

@kaicataldo kaicataldo merged commit b1372da into master Sep 29, 2017
@not-an-aardvark not-an-aardvark deleted the remove-source-code branch September 29, 2017 19:17
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 29, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants