Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Invalid font-size property value issue. #9341

Merged
merged 1 commit into from Sep 24, 2017
Merged

Fix: Invalid font-size property value issue. #9341

merged 1 commit into from Sep 24, 2017

Conversation

H1Gdev
Copy link
Contributor

@H1Gdev H1Gdev commented Sep 22, 2017

"normal" is invalid property value, so change from "normal" to "medium".

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Tell us about your environment

  • ESLint Version: 4.7.1
  • Node Version: 6.9.5
  • npm Version: 4.3.0

What parser (default, Babel-ESLint, etc.) are you using?
default

Please show your full configuration:

module.exports = {
    "env": {
        "browser": true
    },
    "extends": "eslint:recommended",
    "rules": {
        "indent": [
            "error",
            4
        ],
        "linebreak-style": [
            "error",
            "unix"
        ],
        "quotes": [
            "error",
            "single"
        ],
        "semi": [
            "error",
            "always"
        ]
    }
};

What did you do? Please include the actual source code causing the issue.
eslint --format html --output-file lint.html yourfile.js

What did you expect to happen?
output valid css property value html file.

What actually happened? Please include the actual, raw output from ESLint.
output html file included invalid css property value.

What changes did you make? (Give an overview)
change from "normal" to "medium".

Is there anything you'd like reviewers to focus on?
Nothing in particular

"normal" is invalid property value, so change from "normal" to "medium".
@mention-bot
Copy link

@H1Gdev, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JulianLaval and @gajus to be potential reviewers.

@eslintbot
Copy link

LGTM

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contributing!

I'll leave this open for another day in case anyone else wants to review it.

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features labels Sep 23, 2017
@not-an-aardvark
Copy link
Member

Temporarily closing and reopening to restart the Appveyor build.

@not-an-aardvark
Copy link
Member

Thanks for contributing!

@not-an-aardvark not-an-aardvark merged commit 434d9e2 into eslint:master Sep 24, 2017
@H1Gdev H1Gdev deleted the formatter branch September 24, 2017 22:43
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 24, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants