Fix: Revert setting node.parent early (fixes #9331) #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1488b51. Some rules from plugins were relying on the behavior that a a `node.parent` property is only sometines present, and other rules were relying on the behavior that the AST contains no cycles when rules are created.
not-an-aardvark
added
accepted
|
LGTM |
platinumazure
approved these changes
Sep 20, 2017
gyandeeps
approved these changes
Sep 21, 2017
ilyavolodin
approved these changes
Sep 21, 2017
|
Should we release it as a patch release? We haven't merged in anything yet that would prevent us from doing it tomorrow. |
|
Seems reasonable to me. If we're releasing it tomorrow we may want to reopen the release issue and add another comment to prevent people from merging anything else. |
|
Sounds good. I'll reopen release issue. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This reverts commit 1488b51. Some rules
from plugins were relying on the behavior that a a
node.parentproperty is only sometines present, and other rules were relying on the
behavior that the AST contains no cycles when rules are created.
I think we should plan to make this change next major release, since I still think it's an improvement over the existing rule API.
Is there anything you'd like reviewers to focus on?
Nothing in particular