Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Chore: rewrite parseListConfig for a small perf gain." #9325

Merged
merged 8 commits into from Sep 18, 2017
Merged

Revert "Chore: rewrite parseListConfig for a small perf gain." #9325

merged 8 commits into from Sep 18, 2017

Conversation

aladdin-add
Copy link
Member

Reverts #9300

@aladdin-add
Revert "4.7.0"
f9f2a27 
This reverts commit 439e8e6.
@aladdin-add
Revert "Build: changelog update for 4.7.0"
ea438de 
This reverts commit 2ec62f9.
@aladdin-add
Revert "Upgrade: Espree v3.5.1 (fixes eslint#9153) (eslint#9314)"
edf1627 
This reverts commit 787b78b.
@aladdin-add
Revert "Update: run rules after node.parent is already set (fixes e…
057dbe6 
…slint#9122) (eslint#9283)"

This reverts commit 1488b51.
@aladdin-add
Revert "Docs: fix wrong config in max-len example. (eslint#9309)"
b9df6e1 
This reverts commit 4431d68.
@aladdin-add
Revert "Chore: Revert "avoid handling Rules instances in config-valid…
1b2fd93 
…ator" (eslint#9295)"

This reverts commit 9d1df92.
@aladdin-add
Revert "Docs: Fix code snippet to refer to the correct option (eslint…
5e8f775 
…#9313)"

This reverts commit 7d24dde.
@aladdin-add
Revert "�Chore: rewrite parseListConfig for a small perf gain. (eslin…
89d7302 
…t#9300)"

This reverts commit 12388d4.
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @roadhump, @not-an-aardvark and @btmills to be potential reviewers.

@aladdin-add aladdin-add mentioned this pull request Sep 18, 2017
Closed
not-an-aardvark
not-an-aardvark approved these changes Sep 18, 2017
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Sorry, I should have caught this earlier.

It looks like you have some extra empty commits on your branch, but it shouldn't matter after we squash the branch anyway.

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features patch candidate This issue may necessitate a patch release in the next few days labels Sep 18, 2017
@ilyavolodin ilyavolodin merged commit 9226495 into eslint:master Sep 18, 2017
@aladdin-add aladdin-add deleted the revert-9300-perf branch September 20, 2017 11:19
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 18, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features patch candidate This issue may necessitate a patch release in the next few days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aladdin-add @eslintbot @mention-bot @ilyavolodin @not-an-aardvark