Docs: fix wrong config in max-len example. #9309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @scriptdaemon, @iancmyers and @nzakas to be potential reviewers. |
docs/rules/max-len.md
Outdated
| @@ -147,7 +147,7 @@ var longRegExpLiteral = /this is a really really really really really long regul | |||
| Examples of **correct** code for this rule with the `{ "ignorePattern": true }` option: | |||
There was a problem hiding this comment.
I think this line is also incorrect: ignorePattern is a string option, so ignorePattern: true doesn't make sense.
There was a problem hiding this comment.
maybe it make more sense to allow string and regex -- using RegExp(string) can be confusing, and sometimes different behavior. thoughts?
There was a problem hiding this comment.
I think there are multiple issues we're discussing in this PR -- maybe we should separate them:
- The current example in the documentation doesn't work, so I think we should fix it in this PR.
- It seems like the comment parsing for config comments might have confusing behavior with backslashes. (Maybe we should create a new issue for this.)
- It might be simpler for the rule to have a regex option rather than a string. (I think it's unlikely that this will work because we need to support JSON config files which don't support regex. However, feel free to create a new issue for it if you'd like.)
There was a problem hiding this comment.
agree. updated the PR, so it will not block the merge.:)
|
LGTM |
gyandeeps
approved these changes
Sep 15, 2017
|
Closing and reopening to restart the appveyor build. |
ilyavolodin
approved these changes
Sep 15, 2017
btmills
approved these changes
Sep 15, 2017
aladdin-add
added a commit
to aladdin-add/eslint
that referenced
this pull request
Sep 18, 2017
This reverts commit 4431d68.
ilyavolodin
pushed a commit
that referenced
this pull request
Sep 18, 2017
* Revert "4.7.0" This reverts commit 439e8e6. * Revert "Build: changelog update for 4.7.0" This reverts commit 2ec62f9. * Revert "Upgrade: Espree v3.5.1 (fixes #9153) (#9314)" This reverts commit 787b78b. * Revert "Update: run rules after `node.parent` is already set (fixes #9122) (#9283)" This reverts commit 1488b51. * Revert "Docs: fix wrong config in max-len example. (#9309)" This reverts commit 4431d68. * Revert "Chore: Revert "avoid handling Rules instances in config-validator" (#9295)" This reverts commit 9d1df92. * Revert "Docs: Fix code snippet to refer to the correct option (#9313)" This reverts commit 7d24dde. * Revert "�Chore: rewrite parseListConfig for a small perf gain. (#9300)" This reverts commit 12388d4.
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
What changes did you make? (Give an overview)
this regex will cause an error:
Is there anything you'd like reviewers to focus on?
it didn't cause an error, but when apply the config, it didn't work. is this expected?