Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade deps. #9289

Merged
merged 2 commits into from Sep 15, 2017
Merged

Chore: upgrade deps. #9289

merged 2 commits into from Sep 15, 2017

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslintbot
Copy link

LGTM

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think we shouldn't upgrade globals until ESLint v5. The other upgrades are fine by me.

package.json Outdated
@@ -50,7 +50,7 @@
"file-entry-cache": "^2.0.0",
"functional-red-black-tree": "^1.0.1",
"glob": "^7.1.2",
"globals": "^9.17.0",
"globals": "^10.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be a breaking change for ESLint's users, because some globals were removed from the jest environment. (See here)

@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit 838df76 into eslint:master Sep 15, 2017
@aladdin-add aladdin-add deleted the upgrade-dep branch October 5, 2017 16:56
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 15, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants