Chore: avoid applying eslint-env comments twice #9278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @BYK and @alberto to be potential reviewers. |
|
LGTM |
not-an-aardvark
force-pushed
the
double-env-configs
branch
from
62bc13a
to
60fc857
Compare
|
LGTM |
not-an-aardvark
force-pushed
the
double-env-configs
branch
from
60fc857
to
ebeeab8
Compare
|
LGTM |
ilyavolodin
approved these changes
Oct 14, 2017
kaicataldo
approved these changes
Oct 14, 2017
|
Thanks for contributing to ESLint! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
/* eslint-env */comments are processed differently from other directive comments in that they're actually matched by a regex and applied before parsing occurs. This was done as a fix for #2134 in order to allow/* eslint-env */comments to change the parser options. (A side-effect is that some envs are incorrectly added when/* eslint-env */appears in a string rather than a comment, like this, but that's a separate concern.)Since
envsare applied before parsing, it's not necessary to also apply them after parsing as part of the normal comment processing step. This commit removes the double-processing.Is there anything you'd like reviewers to focus on?
Nothing in particular