Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: re-run browserify when generating site #9275

Merged
merged 1 commit into from Sep 10, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (fixes eslint/archive-website#407)

What changes did you make? (Give an overview)

This updates the npm run gensite script to run browserify as part of the site generation, rather than using whatever it finds in build/eslint.js. This has a few advantages:

  • The built file will always be up-to-date (previously, it would reflect the state of the repository whenever npm test was last run).
  • The gensite script won't fail if it's run on its own and there isn't a build/ directory.

Is there anything you'd like reviewers to focus on?

Nothing in particular

(fixes eslint/archive-website#407)

This updates the `npm run gensite` script to run browserify as part of the site generation, rather than using whatever it finds in `build/eslint.js`. This has a few advantages:

* The built file will always be up-to-date (previously, it would reflect the state of the repository whenever `npm test` was last run).
* The gensite script won't fail if it's run on its own and there isn't a `build/` directory.
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly build This change relates to ESLint's build process labels Sep 9, 2017
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @mysticatea and @kaicataldo to be potential reviewers.

@kaicataldo kaicataldo merged commit abc8634 into master Sep 10, 2017
@not-an-aardvark not-an-aardvark deleted the rerun-browserify-build branch September 10, 2017 21:54
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 10, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter has the wrong version number in the demo
6 participants