Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: IIFE and arrow functions in no-invalid-this (fixes #9126) #9258

Merged
merged 1 commit into from Sep 10, 2017

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Fixes #9126.

What changes did you make? (Give an overview)

This PR adds the IIFE of arrow functions into the assignment target detection logic.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Sep 8, 2017
@not-an-aardvark not-an-aardvark merged commit 7685fed into master Sep 10, 2017
@not-an-aardvark not-an-aardvark deleted the issue9126 branch September 10, 2017 18:03
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 10, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"no-invalid-this" gives false-negative result
3 participants