Fix: reuse the AST of source code object in verify #9256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
accepted
|
LGTM |
|
@mysticatea, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @gyandeeps and @nzakas to be potential reviewers. |
|
Oops, thanks for fixing. I think this was introduced in 4b94c6c. |
not-an-aardvark
approved these changes
Sep 8, 2017
not-an-aardvark
added
regression
gyandeeps
approved these changes
Sep 8, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix (template)
Tell us about your environment
masterWhat parser (default, Babel-ESLint, etc.) are you using?
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
Gave a
SourceCodeobject tolinter.verify().In more accurate, I resolved conflictions between #8755 and
master, then this test got broken.What did you expect to happen?
It reuses the AST of the
SourceCodeobject.What actually happened? Please include the actual, raw output from ESLint.
It re-parsed the source code text.
What changes did you make? (Give an overview)
This PR moved the statement
this.sourceCode = textOrSourceCode;to the next ofthis.reset()becausethis.reset()setnulltothis.sourceCode.Is there anything you'd like reviewers to focus on?
Nothing in particular.