Chore: avoid relying on Linter#getScope/markVariableAsUsed in tests #9252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This updates the
Linter
tests to avoid using the privateLinter#getScope
andLinter#markVariableAsUsed
methods. The publiccontext.getScope
andcontext.markVariablesAsUsed
methods are used instead.(refs #9161)
Is there anything you'd like reviewers to focus on?
All of the tests here are changed in the same way. The
spy
method, which was previously a pure node listener, now needs a reference tocontext
so that it can callcontext.getScope
rather thanlinter.getScope
. So the method is now created inside alinter.defineRule
call rather than outside it.