New: add option to report unused eslint-disable directives (fixes #9249) #9250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
core
not-an-aardvark
force-pushed
the
report-unused-disable
branch
from
bd013b8
to
0400514
Compare
|
LGTM |
not-an-aardvark
commented
Sep 7, 2017
| @@ -32,26 +32,27 @@ function compareLocations(itemA, itemB) { | |||
| * comment for two different rules is represented as two directives). | |||
There was a problem hiding this comment.
The business logic changes (i.e. the changes that actually handle directive comments rather than just passing options through the API) are all in this file.
not-an-aardvark
force-pushed
the
report-unused-disable
branch
from
0400514
to
3ce4d02
Compare
|
LGTM |
not-an-aardvark
force-pushed
the
report-unused-disable
branch
from
3ce4d02
to
a5e29e1
Compare
|
LGTM |
not-an-aardvark
added
accepted
not-an-aardvark
force-pushed
the
report-unused-disable
branch
from
a5e29e1
to
8b60563
Compare
|
LGTM |
not-an-aardvark
force-pushed
the
report-unused-disable
branch
from
8b60563
to
0545dd0
Compare
|
LGTM |
btmills
approved these changes
Sep 29, 2017
kaicataldo
approved these changes
Sep 29, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Add something to the core (see #9249)
What changes did you make? (Give an overview)
This adds the
--report-unused-disable-directivesCLI flag, and thereportUnusedDisableDirectivesoption toCLIEngineandLinter, as described in #9249.Is there anything you'd like reviewers to focus on?
Nothing in particular