Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix error in example code for sort-imports (fixes #8734) #9245

Merged
merged 1 commit into from Sep 6, 2017
Merged

Docs: Fix error in example code for sort-imports (fixes #8734) #9245

merged 1 commit into from Sep 6, 2017

Conversation

i-ron-y
Copy link
Contributor

@i-ron-y i-ron-y commented Sep 6, 2017

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Fixed the errors in the examples of correct code for sort-imports.md.

Is there anything you'd like reviewers to focus on?
N/A

@eslintbot
Copy link

LGTM

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly documentation Relates to ESLint's documentation rule Relates to ESLint's core rules labels Sep 6, 2017
@not-an-aardvark not-an-aardvark merged commit 82d8b73 into eslint:master Sep 6, 2017
aladdin-add pushed a commit to aladdin-add/eslint that referenced this pull request Sep 8, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants