Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: shebang error in eslint-disable-new-line; add tests (fixes #9238) #9240

Merged
merged 1 commit into from Sep 8, 2017
Merged

Conversation

i-ron-y
Copy link
Contributor

@i-ron-y i-ron-y commented Sep 6, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
I filtered out shebang comments before comments are processed for the function modifyConfigsFromComments in linter.js. I also added additional tests to the linter.js test file.

Is there anything you'd like reviewers to focus on?
N/A

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@i-ron-y, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrajav, @not-an-aardvark and @gyandeeps to be potential reviewers.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features labels Sep 6, 2017
@not-an-aardvark
Copy link
Member

Just to keep you in the loop: we generally leave bugfix PRs open for at least 48 hours to give people enough time to review the PR or notice issues. So assuming no one requests changes, this should be merged in the next day or two.

@not-an-aardvark not-an-aardvark merged commit 7ba46e6 into eslint:master Sep 8, 2017
aladdin-add pushed a commit to aladdin-add/eslint that referenced this pull request Sep 8, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 8, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants