Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Replace misleading CLA links (#9133) #9232

Merged
merged 1 commit into from Sep 5, 2017
Merged

Docs: Replace misleading CLA links (#9133) #9232

merged 1 commit into from Sep 5, 2017

Conversation

i-ron-y
Copy link
Contributor

@i-ron-y i-ron-y commented Sep 5, 2017

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
I changed the CLA link from https://contribute.jquery.org/cla to https://cla.js.foundation/eslint/eslint in the following pages:

The reason for this change is twofold:

  1. To avoid confusion - https://cla.js.foundation/eslint/eslint is the actual page where ESLint contributors can sign the CLA, not https://contribute.jquery.org/cla
  2. To keep them consistent with the Pull Request Guidelines page which links to https://cla.js.foundation/eslint/eslint

Is there anything you'd like reviewers to focus on?
N/A

@eslintbot
Copy link

LGTM

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@platinumazure platinumazure merged commit 5566e94 into eslint:master Sep 5, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 5, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants