Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove ConfigOps.normalize in favor of ConfigOps.getRuleSeverity #9224

Merged
merged 1 commit into from Sep 4, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This removes the normalize method from config-ops in favor of a getRuleSeverity method.

Previously, ConfigOps.normalize would only convert string severities to numeric severities, but it would still leave severities in arrays, and Linter used a separate getRuleSeverity function to extract them. Now ConfigOps.getRuleSeverity handles both operations, so the getRuleSeverity function in Linter is redundant.

The goal of this change is to (a) reduce the number of places where modules mutate each others' objects, and (b) organize the rule severity logic into one place.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Sep 4, 2017
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @gyandeeps and @mysticatea to be potential reviewers.

@not-an-aardvark not-an-aardvark merged commit c991630 into master Sep 4, 2017
@not-an-aardvark not-an-aardvark deleted the config-ops-get-rule-severity branch September 4, 2017 21:11
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 4, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants