Fix: off-by-one error in eslint-disable comment checking

[not-an-aardvark]

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Tell us about your environment

• ESLint Version: master
• Node Version: 8.4.0
• npm Version: 5.3.0

What parser (default, Babel-ESLint, etc.) are you using?

N/A

Please show your full configuration:

N/A

What did you do? Please include the actual source code causing the issue.

const eslint = require("eslint");
const linter = new eslint.Linter();

linter.defineRule("checker", context => ({
    Program() {
        context.report({ loc: { line: 1, column: 0 }, message: "foo" });
    }
}));

linter.verify(" /* eslint-disable */", { rules: { checker: "error" } });

What did you expect to happen?

I expected an error to be reported, because the report location is before the start of the eslint-disable comment.

What actually happened? Please include the actual, raw output from ESLint.

No error was reported. An empty array was returned.

What changes did you make? (Give an overview)

This updates isDisabledByReportingConfig in Linter to fix an off-by-one error introduced in d672aef. isDisabledByReportingConfig is now accepting locations with 1-based columns rather than 0-based columns, so it needs to offset them appropriately when comparing them against comments with 0-based columns.

Is there anything you'd like reviewers to focus on?

Nothing in particular

[eslintbot]

LGTM

[mention-bot]

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alberto, @mysticatea and @gyandeeps to be potential reviewers.