Chore: make parse() a pure function in Linter (refs #9161) #9183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @nzakas and @mysticatea to be potential reviewers. |
not-an-aardvark
force-pushed
the
parse-pure
branch
from
b1db6fe
to
974904b
Compare
|
LGTM |
gyandeeps
approved these changes
Aug 30, 2017
not-an-aardvark
force-pushed
the
parse-pure
branch
from
974904b
to
1329129
Compare
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This refactors the private
parsefunction inlinter.jsto be a pure function. Instead of adding an error to a providedmessagesarray, it now returns an object with a booleansuccessproperty. It also handles extractingparserServiceswhenparseForESLintis used, which simplifies the logic in theLinter#verifymethod a bit.Is there anything you'd like reviewers to focus on?
Nothing in particular