no-unused-vars: Improve error messages to include the allowed patterns #9176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@TheSavior, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @mysticatea and @nzakas to be potential reviewers. |
tests/lib/rules/no-unused-vars.js
Outdated
| { | ||
| code: "var _a; var b;", | ||
| options: [{ vars: "all", varsIgnorePattern: "^_" }], | ||
| errors: [{ message: "'b' is defined but never used. Allowed unused vars must match '^_'", line: 1, column: 13 }] |
There was a problem hiding this comment.
Instead of surrounding the matcher with single quotes, would it be better to surround it with / characters instead to clarify that it's a regex?
'b' is defined but never used. Allowed unused vars must match /^_/.
There was a problem hiding this comment.
Yeah, I've wondered that and I agree it makes it more clear that it is a regex.
|
The report messages look good to me. As a nitpick, I think we generally try to make report messages end in a period, but it's not a big deal either way. |
TheSavior
changed the title
TheSavior
force-pushed
the
no-unused-vars-messages
branch
3 times, most recently
from
87f19bc
to
2dd2407
Compare
not-an-aardvark
added
enhancement
TheSavior
force-pushed
the
no-unused-vars-messages
branch
from
2dd2407
to
a8d26f6
Compare
TheSavior
force-pushed
the
no-unused-vars-messages
branch
from
a8d26f6
to
bf447e0
Compare
|
LGTM |
platinumazure
approved these changes
Aug 29, 2017
|
Yay! It builds successfully. |
not-an-aardvark
added
accepted
btmills
approved these changes
Aug 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP and is just providing an implementation of tests to ensure the cases are satisfactory before updating the rule.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What rule do you want to change?
no-unused-vars
Does this change cause the rule to produce more or fewer warnings?
Neither
How will the change be implemented? (New option, new default behavior, etc.)?
Updating the error messages
Please provide some example code that this change will affect:
See #9171
What changes did you make? (Give an overview)
Improving the error messages to give a hint as to what the allowed pattern is.
Is there anything you'd like reviewers to focus on?