Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: avoid using private Linter APIs in astUtils tests (refs #9161) #9173

Merged
merged 1 commit into from Aug 30, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This updates the tests for ast-utils to use the public Linter#defineRule API rather than the private Linter#on API.

Is there anything you'd like reviewers to focus on?

Nothing in particular

This updates the tests for `ast-utils` to use the public `Linter#defineRule` API rather than the private `Linter#on` API.
@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Aug 28, 2017
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @mysticatea and @kaicataldo to be potential reviewers.


linter.reset();
linter.on("CallExpression", checker);
linter.verify("foo.apply(`test`, a, b);", {}, filename, true);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was previously broken because it's calling linter.verify on ES6 code without the appropriate parser options. The listener function contained all the assertions, but it was never called due to the parsing error.

@not-an-aardvark not-an-aardvark merged commit 6fb32e1 into master Aug 30, 2017
@not-an-aardvark not-an-aardvark deleted the no-private-api-ast-utils branch August 30, 2017 18:13
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 27, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants