Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: avoid unnecessarily complex forEach calls in no-extra-parens #9159

Merged
merged 1 commit into from Aug 26, 2017

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Aug 26, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This updates no-extra-parens to avoid unnecessarily complex forEach calls.

I'm not sure why it was done like this before. My guess is that someone got confused and thought node.arguments was an arguments object (so it wouldn't have a forEach method, which would make the [].forEach.call workaround necessary), even though it's actually just a regular array.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Aug 26, 2017
@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit fcb7bb4 into master Aug 26, 2017
@not-an-aardvark not-an-aardvark deleted the no-extra-parens-strange-loop branch August 26, 2017 06:00
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 23, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants