Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: \n escaping exclusion for quotes #9134

Closed
wants to merge 1 commit into from
Closed

Conversation

avimar
Copy link
Contributor

@avimar avimar commented Aug 21, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Docs about when new lines are an auto-exclusion or not.

As per this commenter: #9069 (comment)

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Aug 21, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @avimar! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@avimar avimar changed the title fix docs for \n escaping exclusion for quotes Docs: \n escaping exclusion for quotes Aug 21, 2017
@avimar
Copy link
Contributor Author

avimar commented Aug 21, 2017

.. I had to re-submit it to fit the commit message because I was using github website, I didn't see how to amend. New pull: #9135

@avimar avimar closed this Aug 21, 2017
@avimar avimar deleted the patch-1 branch August 21, 2017 18:43
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 19, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants