Chore: improve coverage in lib/*.js #9130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was checking to see if a function is the left child of an AssignmentExpression, which isn't possible.
This test was intended to verify that --print-config was disallowed with --stdin. However, the test didn't have an argument with --print-config, so the command failed option validation and never made it to the logic that it was supposed to test.
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @roadhump and @mysticatea to be potential reviewers. |
platinumazure
approved these changes
Aug 20, 2017
gyandeeps
approved these changes
Aug 20, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This adds some tests for code in
lib/*.jsthat wasn't previously covered, and removes some code which is now unreachable.Is there anything you'd like reviewers to focus on?
Nothing in particular