Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update chalk to 2.x release #9115

Merged
merged 3 commits into from Aug 18, 2017
Merged

chore: Update chalk to 2.x release #9115

merged 3 commits into from Aug 18, 2017

Conversation

ntwb
Copy link
Contributor

@ntwb ntwb commented Aug 16, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Update chalk to the latest major 2.x branch from 1.x
• Release notes: https://github.com/chalk/chalk/releases/tag/v2.0.0
• Changelog for chalk 1.1.3 to 2.0.0 changes chalk/chalk@v1.1.3...v2.0.0

chalk 2.0.0 breaking change (via release notes)
• Removed chalk.stripColor(). Use the strip-ansi package directly instead.

This PR adds the strip-ansi package replacing instances of chalk.stripColor() with strip-ansi

Is there anything you'd like reviewers to focus on?

The new package strip-ansi was added to dependencies as it's required by the stylish formatter which is shipped as part of the build, I think this is what is required just as chalk is and was previously in the same regard.

@jsf-clabot
Copy link

jsf-clabot commented Aug 16, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @ntwb! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@eslintbot
Copy link

Thanks for the pull request, @ntwb! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@ntwb
Copy link
Contributor Author

ntwb commented Aug 16, 2017

I've amended the commit summary though as my fork didn't have the origin branches I had to merge these back to my fork, feels wrong to edit that commit to begin with Update 🤔

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@not-an-aardvark not-an-aardvark merged commit d00e24f into eslint:master Aug 18, 2017
@ntwb ntwb deleted the update/chalk branch August 18, 2017 03:25
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 16, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants