Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: allow arbitrary nodes to be ignored in indent (fixes #8594) #9105

Merged
merged 1 commit into from Aug 19, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Changes an existing rule (#8594)

What changes did you make? (Give an overview)

This adds an option to the indent rule to allow the indentation checking for an arbitrary node type to be ignored, as described in #8594. This should make it easier for users to use the indent rule even if they think a different indentation should be enforced for a particular node type.

Is there anything you'd like reviewers to focus on?

Nothing in particular

This adds an option to the `indent` rule to allow the indentation checking for an arbitrary node type to be ignored, as described in #8594. This should make it easier for users to use the `indent` rule even if they think a different indentation should be enforced for a particular node type.
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint indent Relates to the `indent` rule rule Relates to ESLint's core rules labels Aug 14, 2017
@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit decdd2c into master Aug 19, 2017
@not-an-aardvark not-an-aardvark deleted the indent-ignore-option branch August 19, 2017 01:58
futagoza added a commit to futagoza/eslint-config-futagozaryuu that referenced this pull request Aug 24, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 18, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint indent Relates to the `indent` rule rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants