Update: Include files with no messages in junit results (#9093)

[Sean-Der]

What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix #9093

What changes did you make? (Give an overview)
Currently when a file has no errors there isn't an entry in the junit results. This breaks some junit parsers as they expect at least one result. It also provides more data since now you know how many files have actually been parsed.

Is there anything you'd like reviewers to focus on?

[eslintbot]

LGTM

[mention-bot]

@Sean-Der, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xjamundx, @mysticatea and @kaicataldo to be potential reviewers.

[eslintbot]

LGTM

[not-an-aardvark]

Thanks for the pull request!

I'm not very familiar with junit formatters or their expected output, so I can't speak to whether this change is a good idea -- I'll let someone else on the team make that determination. However, assuming that the change is a good idea in general, this implementation looks good to me.

[platinumazure]

As an aside, it would be so nice if we supported a --formatter-options CLI option where the option could just get passed into the formatter, and then the formatter could actually follow either behavior and the user could decide.

[Sean-Der]

Thanks for the review @not-an-aardvark !

@platinumazure I would be more then happy to write that feature! I could see the junit change being controversial, so happy to do whatever makes everyone happy.

[platinumazure]

Thanks, don't jump too quickly on that, the team has discussed it in the past and vetoed it and I've been the lone dissenter for a while. :-)

…

On Aug 9, 2017 10:56 AM, "Sean DuBois" ***@***.***> wrote: Thanks for the review @not-an-aardvark <https://github.com/not-an-aardvark> ! @platinumazure <https://github.com/platinumazure> I would be more then happy to write that feature! I could see the junit change being controversial, so happy to do whatever makes everyone happy. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9094 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARWejBIzas6kzSzYW17EznGWQCaukUEks5sWdaVgaJpZM4Oxpaa> .

[not-an-aardvark]

I'm going to go ahead and accept this because the previous behavior seems like a bug to me, and no one has said otherwise. Thanks again!