Chore: Remove extra space in blogpost template #9088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@kaicataldo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas and @not-an-aardvark to be potential reviewers. |
not-an-aardvark
approved these changes
Aug 7, 2017
| @@ -7,7 +7,7 @@ tags: | |||
| --- | |||
| # ESLint v<%= version %> released | |||
|
|
|||
| We just pushed ESLint v<%- version %>, which is a <%- type %> release upgrade of ESLint. This release <% if (type !== "patch") { %>adds some new features and<% } %> fixes several bugs found in the previous release. <% if (type === "major") { %>This release also has some breaking changes, so please read the following closely. <% } %> | |||
| We just pushed ESLint v<%- version %>, which is a <%- type %> release upgrade of ESLint. This release <% if (type !== "patch") { %>adds some new features and<% } %>fixes several bugs found in the previous release. <% if (type === "major") { %>This release also has some breaking changes, so please read the following closely. <% } %> | |||
There was a problem hiding this comment.
Possibly in another PR, should we fix the pluralization here too to avoid things like eslint/archive-website#372?
There was a problem hiding this comment.
Yeah, let's do it in a separate PR!
gyandeeps
approved these changes
Aug 7, 2017
kaicataldo
changed the title
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Remove an extra space character in the blogpost template. It doesn't actually get rendered on the website, but does exist in markdown files.
Example: eslint/archive-website@e5576a2#diff-4a34709f3e425809d29bd54136cac633R10
Is there anything you'd like reviewers to focus on?
Nothing in particular