Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update instructions for adding TSC members #9086

Merged
merged 1 commit into from Aug 10, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

From last month's TSC meeting, the TSC started using a calendar invite for meetings. When TSC members are added in the future, we should remember to add them to the calendar invite. This commit updates the guidelines for adding TSC members to include that reminder.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Aug 7, 2017
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas and @platinumazure to be potential reviewers.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though technically this might need TSC approval since the Governance document is being modified...?

@not-an-aardvark
Copy link
Member Author

not-an-aardvark commented Aug 7, 2017

LGTM, though technically this might need TSC approval since the Governance document is being modified...?

¯\_(ツ)_/¯ I suppose so. It does seem like it shouldn't be necessary for such a trivial addition though.

TSC Summary: This adds a line to the project governance documentation to indicate that new TSC members should be added to the Google Calendar invite.
TSC Question: (a) Should we add this line? (b) In the future, do trivial changes like this to the governance documentation need to be approved by the TSC?

@not-an-aardvark not-an-aardvark added tsc agenda This issue will be discussed by ESLint's TSC at the next meeting evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 7, 2017
@kaicataldo
Copy link
Member

kaicataldo commented Aug 7, 2017

I really don't think this needs to go to the TSC. We already decided we wanted to try using Google Calendar :)

@platinumazure
Copy link
Member

¯_(ツ)_/¯ I suppose so. It does seem like it shouldn't be necessary for such a trivial addition though.

I guess my take is, all Governance changes should require TSC approval, but maybe those guidelines shouldn't be in Governance since they're more of a practical checklist for what to do with new TSC members, rather than normative guidelines related to how the project should be run.

@kaicataldo kaicataldo removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion tsc agenda This issue will be discussed by ESLint's TSC at the next meeting labels Aug 10, 2017
@kaicataldo
Copy link
Member

Going to go ahead and merge this given the response to this comment

@kaicataldo kaicataldo merged commit 77bcee4 into master Aug 10, 2017
@not-an-aardvark not-an-aardvark deleted the update-maintainer-guide branch August 10, 2017 17:26
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 8, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants