Update: avoid requiring NaN spaces of indentation (fixes #9083) #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the `indent` rule would sometimes expect "NaN spaces" of indentation when an `"off"` option was used.
not-an-aardvark
added
accepted
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @gyandeeps and @valorkin to be potential reviewers. |
gyandeeps
approved these changes
Aug 7, 2017
platinumazure
approved these changes
Aug 7, 2017
Technically no, because the following code was previously considered valid and is now reported. This makes the change semver-minor. /* eslint indent: [error, 2, {CallExpression: {arguments: off}}] */
a(b
, c);This issue has existed since v4.0.0-alpha.0, so in my opinion the fix doesn't need to urgently go into a patch release. (Alternatively, if we want to get this released sooner we could always do another minor release with bugfixes.) |
kaicataldo
approved these changes
Aug 7, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#9083)
What changes did you make? (Give an overview)
This fixes an issue where the
indentrule would sometimes expect "NaN spaces" of indentation when an"off"option was used. The value"off"was incorrectly getting used as a numeric offset, so it was cast to a number, resulting inNaN.Is there anything you'd like reviewers to focus on?
Nothing in particular