Update: add eslint version to error output. (fixes #9037) #9071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @not-an-aardvark and @platinumazure to be potential reviewers. |
platinumazure
previously requested changes
Aug 4, 2017
|
LGTM |
gyandeeps
approved these changes
Aug 4, 2017
kaicataldo
added
cli
nzakas
previously requested changes
Aug 23, 2017
bin/eslint.js
Outdated
|
|
||
| console.error("\nOops! Something went wrong! :("); | ||
| console.error(`\n${template(err.messageData || {})}`); | ||
| console.error(`\nESLint: ${pkg.version}.${template(err.messageData || {})}`); |
There was a problem hiding this comment.
I'd like to see the ESLint version on a separate line for easier reading.
|
Heads up: It looks like the issue hasn't been accepted for this PR. |
|
LGTM |
ilyavolodin
added
accepted
not-an-aardvark
dismissed stale reviews from platinumazure and nzakas
Comments have been addressed.
|
This was accepted by the TSC yesterday (see #9037) |
This was referenced Oct 24, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
add eslint version to error output. (fixes #9037)
Is there anything you'd like reviewers to focus on?
is this will be a breaking change?