New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: enable eslint-plugin/test-case-shorthand-strings. #9067
Chore: enable eslint-plugin/test-case-shorthand-strings. #9067
Conversation
LGTM |
@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @not-an-aardvark and @cschuller to be potential reviewers. |
18cf95e
to
31c899f
Compare
LGTM |
}, | ||
{ | ||
code: unIndent` | ||
`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to make the code example aligned with the unIndent
call here:
// currently:
unIndent`
foo;
`
// after:
unIndent`
foo
`
(Unfortunately, indent
doesn't check this because the template string actually contains spaces. However, the unIndent
function ignores the spaces.)
However, it seems like manually changing everything would probably be very tedious. Separately, maybe we should add something to lib/internal-rules
to enforce "indentation" of code samples inside template literals.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
It looks like there is a merge conflict.
fixed. @not-an-aardvark |
LGTM |
薛定谔的猫 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
7b9bc19
to
962aff6
Compare
LGTM |
LGTM |
Thanks for contributing! |
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
enable eslint-plugin/test-case-shorthand-strings.
Is there anything you'd like reviewers to focus on?
no.