Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable eslint-plugin/test-case-shorthand-strings. #9067

Merged

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)
enable eslint-plugin/test-case-shorthand-strings.

Is there anything you'd like reviewers to focus on?
no.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @not-an-aardvark and @cschuller to be potential reviewers.

@eslintbot
Copy link

LGTM

},
{
code: unIndent`
`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to make the code example aligned with the unIndent call here:

// currently:

unIndent`
        foo;
    `

// after:
unIndent`
    foo
`

(Unfortunately, indent doesn't check this because the template string actually contains spaces. However, the unIndent function ignores the spaces.)

However, it seems like manually changing everything would probably be very tedious. Separately, maybe we should add something to lib/internal-rules to enforce "indentation" of code samples inside template literals.

@aladdin-add aladdin-add changed the title Chore: enable eslint-plugin/test-case-shorthand-strings. [wip] Chore: enable eslint-plugin/test-case-shorthand-strings. Aug 4, 2017
@kaicataldo kaicataldo added chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 5, 2017
@eslintbot
Copy link

LGTM

@aladdin-add aladdin-add changed the title [wip] Chore: enable eslint-plugin/test-case-shorthand-strings. Chore: enable eslint-plugin/test-case-shorthand-strings. Aug 5, 2017
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

It looks like there is a merge conflict.

@aladdin-add
Copy link
Member Author

aladdin-add commented Aug 14, 2017

copy it. I'll fix it asap.

fixed. @not-an-aardvark

@eslintbot
Copy link

LGTM

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Aladdin-ADD
❌ 薛定谔的猫


薛定谔的猫 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@eslintbot
Copy link

LGTM

@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit 1d6a9c0 into eslint:master Aug 14, 2017
@not-an-aardvark
Copy link
Member

Thanks for contributing!

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 14, 2017
@aladdin-add aladdin-add deleted the test-case-shorthand-strings branch August 14, 2017 06:14
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 12, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants